slt/com_clubs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Made Offers a bit more robust and operation atomic

Browse Source
This commit is contained in:
Christian Wolf 2019-06-27 12:03:36 +02:00
parent af506435ac
commit 2da8da6b37
2 changed files with 36 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
src/admin/common/models/club.php
View File

@ -1,5 +1,7 @@
<?php
use Joomla\CMS\Factory;
// No direct access.
defined('_JEXEC') or die;
@ -162,22 +164,35 @@ class CommonClubsModelClub extends AbstractCommonClubsModel
$offerAssocFactory = new CommonClubsModelFactoryOfferassoc();
$offerFactory = new CommonClubsModelFactoryOffer();
foreach($delIds as $id)
$db = Factory::getDbo();
$db->transactionStart(true);
try
{
$delId = (int) $id;
$delObjs = $offerAssocFactory->loadElements("clubid = {$this->getId()} AND offerid = $delId");
foreach($delObjs as $o)
$o->delete();
foreach($delIds as $id)
{
$delId = (int) $id;
$delObjs = $offerAssocFactory->loadElements("clubid = {$this->getId()} AND offerid = $delId");
foreach($delObjs as $o)
$o->delete();
}
foreach($newIds as $id)
{
$newId = (int) $id;
$o = $offerAssocFactory->createNew();
$o->setOffer($offerFactory->loadById($newId));
$o->setClub($this);
$o->save();
}
}
catch (Exception $ex)
{
$db->transactionRollback(true);
throw $ex;
}
foreach($newIds as $id)
{
$newId = (int) $id;
$o = $offerAssocFactory->createNew();
$o->setOffer($offerFactory->loadById($newId));
$o->setClub($this);
$o->save();
}
$db->transactionCommit(true);
}
public function getUsers()

10
src/site/controllers/parts.json.php
View File

@ -349,8 +349,14 @@ class ClubsHelperControllerClub extends AbstractClubsHelperController
// TODO ACL needed
$this->club->setOfferIds($ids);
$this->club->save();
try
{
$this->club->setOfferIds($ids);
}
catch(ElementNotFoundException $ex)
{
throw new InvalidUserDataException('Es gab ein Problem mit der Eingabe. Bitte Seite neu laden und Daten erneut eintragen.');
}
}
}